Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS unit test target TEST_HOST #696

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Fix macOS unit test target TEST_HOST #696

merged 3 commits into from
Oct 24, 2019

Conversation

mjarvis
Copy link
Contributor

@mjarvis mjarvis commented Oct 24, 2019

Resolves #695

Previously, macOS unit test targets would appear to have no test host.

By manually setting the test host in Xcode on the fixture project, I discovered that macOS test hosts require an additional Contents/MacOS/ path component before the product name.

We can manually detect the platform when setting the test host and as such generate the host correctly for macOS unit test targets.

Malcolm Jarvis added 3 commits October 24, 2019 08:46
Resolves #695

Previously, macOS unit test targets would appear to have no test host.

By manually setting the test host in Xcode on the fixture project, I discovered that macOS test hosts require an additional `Contents/MacOS/` path component before the product name.

We can manually detect the platform when setting the test host and as such generate the host correctly for macOS unit test targets.
Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@brentleyjones brentleyjones merged commit d22ab94 into yonaskolb:master Oct 24, 2019
@mjarvis mjarvis deleted the mjarvis/macOS-Test-Host branch October 24, 2019 16:12
@BalintZoo
Copy link

Was this fixed for iOS as well? I'm experiencing the same problems there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Test Host set on macOS
3 participants