Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include unique file only once #599

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Include unique file only once #599

merged 1 commit into from
Aug 19, 2019

Conversation

haritowa
Copy link
Contributor

@haritowa haritowa commented Jun 15, 2019 •
edited
Loading

Fixes #574
Closes #577

@haritowa
Copy link
Contributor Author

@nivanchikov, could you test this PR against your case from the #577

@nivanchikov nivanchikov mentioned this pull request Jun 19, 2019
Closed
@yonaskolb
Copy link
Owner

yonaskolb commented Aug 2, 2019 •
edited
Loading

Thanks @haritowa! This is great if it closes #574 #599 #529 and #577
Could you fix conflicts and add a changelog entry also

@yonaskolb yonaskolb mentioned this pull request Aug 2, 2019
Closed
@haritowa
Copy link
Contributor Author

haritowa commented Aug 2, 2019

@yonaskolb done, but #574 is a separate issue and out of scope

@yonaskolb
Copy link
Owner

Thanks @haritowa, still need a changelog entry before this can be merged

@nivanchikov
Copy link
Contributor

nivanchikov commented Aug 16, 2019 •
edited
Loading

@haritowa can you please add a changelog (if you haven't already)? Would be awesome to get this PR merged

brentleyjones
brentleyjones approved these changes Aug 19, 2019
View reviewed changes
Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now has a changelog. Approving so I can merge it.

@brentleyjones brentleyjones merged commit 8e21cdf into yonaskolb:master Aug 19, 2019
@yonaskolb yonaskolb mentioned this pull request Aug 20, 2019
Closed
@yonaskolb yonaskolb mentioned this pull request Sep 1, 2019
Merged
@akkyie akkyie mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@yonaskolb yonaskolb Awaiting requested review from yonaskolb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target template duplications
4 participants
@haritowa @yonaskolb @nivanchikov @brentleyjones