Filter out NSNull elements from the json dictionary. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @antoniocasero! Yeah there is a known issue with YAMS, and it decoding In terms of fixing it in XcodeGen in the meantime, I'd like to address it at a higher level, perhaps in |
|
@antoniocasero, if you're interested, I've also just invited you to our |
This change allows us to override default BuildSettings. For example: If I want to keep the attribute SWIFT_OBJC_INTERFACE_HEADER_NAME empty, (by default it contains some value). I just need to override this value in the settings spec. Before If I keep property empty, then in the generated settings the value appear as <null>. The method implemented recursively loop through the json dictionary looking for NSNull objects and replace them by an empty string. Filter out NSNull elements from the json dictionary. This change allows us to override default BuildSettings. For example: If I want to keep the attribute SWIFT_OBJC_INTERFACE_HEADER_NAME empty, (by default it contains some value). I just need to override this value in the settings spec. Before If I keep property empty, then in the generated settings the value appear as <null>. The method implemented recursively loop through the json dictionary looking for NSNull objects and replace them by an empty string.
be69a86
to
62f72d3
Compare
|
Done. Let me know what you think. |
|
Looks like this will do the trick, thanks @antoniocasero! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows overriding default BuildSettings.
For example:
If I want to keep the attribute SWIFT_OBJC_INTERFACE_HEADER_NAME empty,
(by default it contains some value). I just need to override this value
in the settings spec.
Previously, If I keep property empty, the generated settings value
appear as .