Bug carthage dependencies with different platform #465
Conversation
|
Hmm, maybe this behaviour is indicative of a deeper issue in that targets shouldn't be able to specify target dependencies that aren't the same platform. That could be added to the spec validation pass. Or do you have some weird case where one target has a dependency on a target with a different platform? Maybe there's watchOS extension case or something I'm not thinking of |
|
The project generating is correct. In iOS bundle can be watchOS app. I am not sure, but I think same behaviour can be achieved with tvOS too. |
|
Could you also add a changelog entry Also can you explain a use case that this fixes? The tests use Would another way of thinking of this be don't include carthage dependencies from app targets? |
|
Changelog is updated. It is real use case. At my project we have 2 dependecies. Name of first dependency is Core. The name is same for all platforms. The name of second dependency is Platform_platformName eg. Platform_iOS or Platform_watchOS. The problem was that carthage imported framework Platform_watchOS to iOS app. |
|
I think not importing app dependencies would be correct solution for this problem. I also think it would be better solution than current one. |
|
I have multiple examples of libs that behave like this. I’ll post them asap |
|
Hi @yonaskolb, Is is possible to merge this PR or is it required to implement the solution you suggested? Thanks |
| @@ -517,6 +517,23 @@ class SourceGeneratorTests: XCTestCase { | |||
| try expect(sourcesBuildPhase.files.count) == 1 | |||
| } | |||
|
|
|||
| $0.it("add only carthage dependencies with same platform", closure: { | |||
There was a problem hiding this comment.
Nitpick: Can this be made a trailing closure
|
@raptorxcz I guess there's nothing wrong with this directly, so we can merge it. Just needs a rebase and a small tweak |
|
Updated in ec60901. |
When project is generated, then in iOS app are added all carthage dependencies.
This behaviour is wrong, because iOS target can have watchOS target as a dependency.