Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdk dependency type #430

Merged
merged 2 commits into from
Nov 4, 2018
Merged

Add sdk dependency type #430

merged 2 commits into from
Nov 4, 2018

Conversation

yonaskolb
Copy link
Owner

@yonaskolb yonaskolb commented Nov 2, 2018 •
edited
Loading

This adds a new sdk dependency type

targets:
  MyApp
    dependencies:
      - sdk: Contacts.framework
      - sdk: libc++.tbd

Resolves #11

@yonaskolb yonaskolb mentioned this pull request Nov 2, 2018
Closed
@yonaskolb yonaskolb mentioned this pull request Nov 2, 2018
Closed
rastersize
rastersize approved these changes Nov 2, 2018
View reviewed changes
Copy link

@rastersize rastersize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@yonaskolb yonaskolb force-pushed the sdk_dependencies branch 2 times, most recently from de187ba to 75507e3 Compare November 4, 2018 09:33
@yonaskolb yonaskolb changed the title Add sdkFramework dependency type Add sdk dependency type Nov 4, 2018
@yonaskolb yonaskolb merged commit 19f445b into master Nov 4, 2018
@yonaskolb yonaskolb deleted the sdk_dependencies branch November 4, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastersize rastersize rastersize approved these changes

@brentleyjones brentleyjones Awaiting requested review from brentleyjones

@rahul-malik rahul-malik Awaiting requested review from rahul-malik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yonaskolb @rastersize