Add additional params to archive action #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/ProjectSpec/Scheme.swift
Outdated
| @@ -150,14 +150,20 @@ public struct Scheme: Equatable { | |||
|
|
|||
| public struct Archive: BuildAction { | |||
| public var config: String? | |||
| public var revealArchiveInOrganizer: Bool | |||
| public var customArchiveName: String? | |||
There was a problem hiding this comment.
The archive name is shown before revealArchiveInOrganizer in the dialog. Can you swap these (here and below) to match that?
There was a problem hiding this comment.
@brentleyjones This is the order of an xcproj's ArchiveAction initializer, but I can change it here for sure.
yonaskolb
reviewed
Aug 2, 2018
| @@ -133,7 +133,8 @@ public class ProjectGenerator { | |||
|
|
|||
| let archiveAction = XCScheme.ArchiveAction( | |||
| buildConfiguration: scheme.archive?.config ?? defaultReleaseConfig.name, | |||
| revealArchiveInOrganizer: true, | |||
| revealArchiveInOrganizer: scheme.archive?.revealArchiveInOrganizer ?? true, | |||
| customArchiveName: scheme.archive?.customArchiveName ?? nil, | |||
There was a problem hiding this comment.
Nitpick - the ?? nil here is redundant
|
Nice, thanks @sxua! |
|
Could you add the new options in https://github.com/yonaskolb/XcodeGen/blob/master/Docs/ProjectSpec.md#scheme under a new |
|
@yonaskolb Good catch, thanks! |
sxua
force-pushed
the
scheme-archive-additions
branch
from
7285c1d
to
769c49f
Compare
|
@yonaskolb Should be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an ability to customize archive name and whether it should be revealed in organizer or not. Basically, one can set options displayed on an image below via
project.yml