Add showEnvVars to build scripts #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
commented
Jul 19, 2018
| FR_783122899910 /* App_iOS_Tests.xctest */, | ||
| FR_123503999387 /* App_iOS_UITests.xctest */, | ||
| FR_825232110500 /* App_iOS.app */, |
There was a problem hiding this comment.
Assuming this was out of date?
brentleyjones
approved these changes
Jul 20, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Change Log | |||
|
|
|||
| ## Master | |||
| - Added `showEnvVars` to build scripts to disable printing the environment [351](https://github.com/yonaskolb/XcodeGen/pull/351) @keith | |||
There was a problem hiding this comment.
Should this be under an #### Added section?
Docs/ProjectSpec.md
Outdated
| @@ -353,6 +353,7 @@ Run script build phases added via **prebuildScripts** or **postBuildScripts**. T | |||
| - [ ] **outputFiles**: **[String]** - list of output files | |||
| - [ ] **shell**: **String** - shell used for the script. Defaults to `/bin/sh` | |||
| - [ ] **runOnlyWhenInstalling**: **Bool** - whether the script is only run when installing (`runOnlyForDeploymentPostprocessing`). Defaults to no | |||
| - [ ] **showEnvVars**: **Bool** - whether the environment variables accessible to the script show be printed to the build log. Defaults to yes | |||
There was a problem hiding this comment.
To mirror the dialog, should this be placed above runOnlyWhenInstalling?
This allows us to disable printing the environment in build logs.
yonaskolb
approved these changes
Jul 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to disable printing the environment in build logs.