Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for swiftcrossimport folders #1317

Merged
merged 8 commits into from
Jan 25, 2023

Conversation

Iron-Ham
Copy link
Contributor

@Iron-Ham Iron-Ham commented Jan 21, 2023

Overview

closes #1315

This PR implements support for swiftcrossimport by:

  • Adding the swiftcrossimport folder-type as an extension on Xcode such that it's recognized as a wrapper.
  • Adding a special case for the swiftcrossimport within framework targets to map correctly.

See https://gist.github.com/beccadax/8f35216340e829efa5e9c1fc090fda09#declaring-a-cross-import-overlay for details

@Iron-Ham Iron-Ham marked this pull request as ready for review January 21, 2023 18:38
@Iron-Ham Iron-Ham changed the title Naive support for swiftcrossimport Support for swiftcrossimport folders Jan 21, 2023
Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Iron-Ham. While I'm not familiar with cross import folders, this looks ok to me if it's working for you.
It would be great if you could add an example of one of these files (even if it's empty) to the TestProject fixture https://github.com/yonaskolb/XcodeGen/blob/master/Tests/Fixtures/TestProject/project.yml

@yonaskolb
Copy link
Owner

Great thanks, nearly there

  • the diffs that are generated after running the tests need to be checked in
  • tests are failing due to a small casing issue in type: Framework

@yonaskolb yonaskolb merged commit 366981b into yonaskolb:master Jan 25, 2023
@Iron-Ham Iron-Ham deleted the hs/crossimport branch January 25, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cross-import-modules
2 participants