Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Glob crash #1181

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Fixed Glob crash #1181

merged 1 commit into from
Mar 6, 2022

Conversation

tr1ckyf0x
Copy link
Contributor

yonaskolb
yonaskolb reviewed Mar 1, 2022
View reviewed changes
Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @tr1ckyf0x. That property wrapper looks useful. Could you add a changelog entry as well please

@tr1ckyf0x tr1ckyf0x requested a review from yonaskolb March 1, 2022 07:12
@yonaskolb
Copy link
Owner

Thanks!

@yonaskolb yonaskolb merged commit a10c7c4 into yonaskolb:master Mar 6, 2022
@tr1ckyf0x
Copy link
Contributor Author

@yonaskolb Thanks for your approval. Could you, please, publish a minor release?

@tr1ckyf0x tr1ckyf0x deleted the fix-crash branch March 6, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonaskolb yonaskolb yonaskolb approved these changes

@Dm94st Dm94st Dm94st approved these changes

@Alptwo Alptwo Alptwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tr1ckyf0x @yonaskolb @Dm94st @Alptwo