Support test target for local Swift Package #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kohki Miki <[email protected]>
Co-authored-by: Yonas Kolb <[email protected]>
|
@yonaskolb I worked #1074 (review), please check it |
kateinoigakukun
approved these changes
Feb 2, 2022
|
@freddi-kit I had a few suggestions for your code in the previous PR: #1168 |
|
Let me check it |
|
@freddi-kit I re-applied the current branch: #1170, I hope that helps. Please let me know if you have any questions/thoughts. |
|
Is there any chance this will be merged any time soon ? |
|
@yonaskolb @freddi-kit 👋 What needs to be done in order to get this one merged? |
yonaskolb
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #1074 for some reason
Close: #1050