Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #36

Closed
wants to merge 1 commit into from
Closed

Fix typos #36

wants to merge 1 commit into from

Conversation

katrinleinweber
Copy link

See diff ;-) I hope this was not an intentional duplication of the. I guessed it was just copied from some template with that typo.

@bradymholt
Copy link
Member

bradymholt commented Dec 31, 2018

Thanks @katrinleinweber ! It looks like the typo itself is actually in the Swagger template here: https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/ruby/base_object.mustache#L8. So, the next time we generate the typo would come back 😦 . But, we can override the template to fix it. Would you be up for copying the template file into this directory and then fixing the typo there? That way the fix will persist next time generate as well.

Thank you!

@katrinleinweber
Copy link
Author

I'm guessing swagger-api/swagger-codegen#9019 makes even more sense in the long-run, albeit probably taking longer to trickle down initially, doesn't it?

@bradymholt
Copy link
Member

@katrinleinweber Yes! That's probably the best place so we don't have to override the template just to change the typo. Thanks for submitting that on the original repo! Are you ok with us closing this PR out and waiting for that change to come down from the Swagger repo?

@katrinleinweber
Copy link
Author

Sure :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants