Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic when Package returns nil #2

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Conversation

SVilgelm
Copy link
Contributor

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1010fe448]

goroutine 41605 [running]:
github.com/ykadowak/zerologlint.isInLogPkg(0x101404088?)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/github.com/ykadowak/zerologlint/zerologlint.go:87 +0x68
github.com/ykadowak/zerologlint.run(0x140af2c1860)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/github.com/ykadowak/zerologlint/zerologlint.go:41 +0x1d0
golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce(0x1400f649900)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:762 +0x88c
sync.(*Once).doSlow(0x140038da798?, 0x100e6fec8?)
        /Users/sergeyvilgelm/go/go1.20.1/src/sync/once.go:74 +0x100
sync.(*Once).Do(...)
        /Users/sergeyvilgelm/go/go1.20.1/src/sync/once.go:65
golang.org/x/tools/go/analysis/internal/checker.(*action).exec(0x140267aef00?)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:678 +0x40
golang.org/x/tools/go/analysis/internal/checker.execAll.func1(0x0?)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:666 +0x24
created by golang.org/x/tools/go/analysis/internal/checker.execAll
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:672 +0x154

```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1010fe448]

goroutine 41605 [running]:
github.com/ykadowak/zerologlint.isInLogPkg(0x101404088?)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/github.com/ykadowak/zerologlint/zerologlint.go:87 +0x68
github.com/ykadowak/zerologlint.run(0x140af2c1860)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/github.com/ykadowak/zerologlint/zerologlint.go:41 +0x1d0
golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce(0x1400f649900)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:762 +0x88c
sync.(*Once).doSlow(0x140038da798?, 0x100e6fec8?)
        /Users/sergeyvilgelm/go/go1.20.1/src/sync/once.go:74 +0x100
sync.(*Once).Do(...)
        /Users/sergeyvilgelm/go/go1.20.1/src/sync/once.go:65
golang.org/x/tools/go/analysis/internal/checker.(*action).exec(0x140267aef00?)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:678 +0x40
golang.org/x/tools/go/analysis/internal/checker.execAll.func1(0x0?)
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:666 +0x24
created by golang.org/x/tools/go/analysis/internal/checker.execAll
        /Users/sergeyvilgelm/Library/Mobile Documents/com~apple~CloudDocs/projects/sv-tools/gochecker/vendor/golang.org/x/tools/go/analysis/internal/checker/checker.go:672 +0x154
```
Copy link
Owner

@ykadowak ykadowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

If you happen to be an expert in this field, could you please tell me why this happens? I found this reproducible case like below but no idea why this returns nil on v.Package.

package a

import "golang.org/x/exp/slices"

func package_nil() {
	s := []int{1, 2, 3}
	slices.Sort(s)
}

@ykadowak ykadowak merged commit 0a2a04b into ykadowak:main Mar 26, 2023
@SVilgelm SVilgelm deleted the fix-panic branch March 26, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants