Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

talbenbasat
Copy link

Add package.json
Updated Israel data

New package.json
Copy link
Owner

@yjlou yjlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tal,

Thanks for contributing to this repo. I am a new learner for nodejs. Do you mind explaining to me a little bit about what the difference in node and nodejs and why you think node is better than nodejs in this case?

If you don't mind, could you also add few more context in the commit log why package.json is required here?

For the input/output.json files, no worries about it. I will update them periodically (once a day for now). Let me know if you think more frequently is better.

Thanks in advance.

@Stimim
Copy link
Collaborator

Stimim commented Mar 16, 2020

Hi @talbenbasat,

Thanks for creating the pull request. Can you remove the "update data" part from the pull request, and left the "adding package.json" and "use node instead of nodejs" parts?
I think it is nice to have package.json, so we only need to "npm install" to install all the packages we need.

@yjlou Regarding node vs nodejs, if you download and install nodejs from offical site, the default exported binaries are "node", "npm" and "npx". So I also agree with using "node" instead of "nodejs".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants