pgsql, oci and mssql schemas cleanup and implemented findUniqueIndexes #7867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nineinchnick
commented
Mar 24, 2015
nineinchnick
commented
- removed processing of pgsql unique index with expressions;
- added findUniqueIndexes for oci and mssql;
- cleaned up oci and mssql schema
|
Remember to apply fixes from #7868 to |
…UniqueIndexes for oci and mssql; cleaned up oci and mssql schema
nineinchnick
force-pushed
the
schema-findUniqueIndex-cleanup
branch
from
1bbfe2c
to
0b7bb1d
Compare
| AND ud.type='TRIGGER' | ||
| AND ud.referenced_type='SEQUENCE' | ||
| SQL; | ||
| $sequenceName = $this->db->createCommand($seq_name_sql, [':tableName' => $tableName])->queryScalar(); |
There was a problem hiding this comment.
Looks like it's missing the fix against PDO::ATTR_CASE from #7868.
There was a problem hiding this comment.
Do you need to apply more changes to it?
There was a problem hiding this comment.
Oh wait, there's queryScalar() so it's fine here. The whole PR is ready.
|
Changelog? |
|
@samdark done. And I keep forgetting about adding [skip CI] to the commit message. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.