Added to the basic app, fixed config, added to core commands. #1759
Conversation
|
also @qiangxue do we need to have some |
|
Related with #1756 |
| @@ -19,6 +22,17 @@ | |||
| ], | |||
| ], | |||
| ], | |||
| 'db' => [ | |||
| 'class' => 'yii\db\Connection', | |||
| 'dsn' => 'mysql:host=localhost;dbname=yii2basic', | |||
There was a problem hiding this comment.
Please use yii2_basic to be consistent with DB setting in other places.
There was a problem hiding this comment.
yep, i was using it as here https://github.com/yiisoft/yii2/blob/master/apps/basic/config/web.php#L34
There was a problem hiding this comment.
Just one comment...
Maybe it would be cleaner to separate db config in a separated file, just as $params.
That would help sharing (and versioning) the main config file wile each developer has it's own database configuration (ignored by CVS) without problem.
There was a problem hiding this comment.
@qiangxue should it be?
There was a problem hiding this comment.
this is not part of this PR in general it is a good idea. Not sure if we should do it in basic app. Discussion should go in a separate issue.
There was a problem hiding this comment.
yep, could you maybe create it?
|
I think we need |
ok. |
|
Added confirmation. Ready for review. No sure if we for example need to add |
| { | ||
| if ($this->getFixtureManager() == null) { |
|
Done, can be reviewed. |
Added to the basic app, fixed config, added to core commands.
|
Thanks! |
|
@cebe also change alias to |
|
|
I added to the basic application
console.phpconfig to avoid unnecessary exception withfixtures path is not configured rightand added db config (dbis needed for apply/clear actions), i also added foldertemplateswhere by default will be hosted templates foryii2-faker, so user should not worry how to configure it and everything will be by default for him.Added fixture to the core commands. Improved some messages and checks.