Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement console color converters #746

Closed
3 of 5 tasks
cebe opened this issue Aug 12, 2013 · 5 comments
Closed
3 of 5 tasks

Implement console color converters #746

cebe opened this issue Aug 12, 2013 · 5 comments

Comments

@cebe
Copy link
Member

cebe commented Aug 12, 2013

Implement methods to convert:

  • ANSI formatted string to HTML (for displaying console job output on websites)
  • simple Markdown to ANSI formatted string to allow console color support in Console Controller action documentation which will be shown by HelpController

Therefore the following methods have to be reworked/refactored/merged:

  • yii\helpers\ConsoleBase::ansiToHtml()
  • yii\helpers\ConsoleBase::markdownToAnsi()
  • yii\helpers\ConsoleBase::renderColoredString()
  • yii\helpers\ConsoleBase::escape()

Console Color Support: #33

Further todo:

@ghost ghost assigned cebe Aug 12, 2013
@samdark
Copy link
Member

samdark commented Aug 12, 2013

Current ansiToHtml is PHP 5.4 only btw.

@cebe
Copy link
Member Author

cebe commented Aug 12, 2013

Why do you think that?

@samdark
Copy link
Member

samdark commented Aug 12, 2013

You're using self:: inside anonymous function.

@qiangxue qiangxue modified the milestones: 2.1, 2.0 RC, 2.0 GA Apr 16, 2014
@samdark
Copy link
Member

samdark commented Jun 23, 2014

@cebe what's left one this one?

@cebe
Copy link
Member Author

cebe commented Jun 24, 2014

Need to refactor all the conversion related functions, they do not really work in all cases.

cebe added a commit that referenced this issue Jun 25, 2014
@cebe cebe closed this as completed Jun 25, 2014
cebe added a commit that referenced this issue Jun 25, 2014
tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014
tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014
tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants