PHP Compile error since last update

[davey013]

Since last update i get this error (PHP Compile Error):

Declaration of yii\base\ArrayableTrait::toArray(array $fields = Array, array $expand = Array, $recursive = true) must be compatible with yii\base\Arrayable::toArray()

[samdark]

Can you post full error stack?

[davey013]

I get this on every page (even gii)

[samdark]

Aha. That is yii\base\Model that both implements Arrayable and uses ArrayableTrait which has different signatures for toArray.

@qiangxue seems to be your change for API. Can you take a look?

[o-rey]

I wonder why I'm not getting this error (updated 5 min ago to see it for myself).

UPD: php 5.5.3

[samdark]

@davey-w which PHP version do you have?

[arashkarimian]

@samdark same here, 5.4.12

[samdark]

@o-rey are you using any models? error_reporting(-1)?

[o-rey]

@samdark yes, I use a lot of models :) And no, it just works. No errors/notices at all. Php 5.5.3 / ubuntu. Any special code I should run to get into this?

I remember some strange things happened some time ago, but they were caused by buggy opcache in my installation.

[samdark]

Hmm, actually tried advanced application with lots of models and no error appeared. I have 5.5.4.

[davey013]

I'm running on PHP 5.4.12

[samdark]

Tried 5.4.20 as well. No error.

[subdee]

I think it was an issue in PHP 5.4.12 which was fixed in 5.4.14.

Not sure if it's related though.

[davey013]

Hmm i see, is there a way to avoid this? Since i'm running WAMP (64-bit) and 5.4.12 is only available for that.

[qiangxue]

We may need to confirm if this is indeed an issue introduced in 5.4.12, and what about 5.4.11 and 5.4.13.

@subdee Could you please try the following three pieces of code (separately) and see if they work fine?

class Test11
{
    public function test()
    {
    }
}

class Test12 extends Test11
{
    public function test($a = 1)
    {
    }
}

interface Test21
{
    public function test();
}

class Test22 implements Test21
{
    public function test($a = 1)
    {
    }
}

interface Test31
{
    public function test();
}

trait Test31Trait
{
    public function test($a = 1)
    {
    }
}

class Test32 implements Test31
{
    use Test31Trait;
}

Reopened for as further investigation is needed.

[subdee]

@qiangxue Only the last one with the trait fails on php 5.4.12 and 5.4.13

[o-rey]

PHP Version 5.4.4-14+deb7u7 - all is well.

[qiangxue]

@o-rey Do you mean 5.4.4 to 5.4.14 all worked fine? I'm curious how did you manage to test so many versions easily?

[subdee]

haha I think he meant a specific revision of 5.4.4 for Debian

[o-rey]

@qiangxue oops sorry :) it's only one installation that I have by chance on remote.

[cebe]

looks like travis can do this for us: 315cfbc https://travis-ci.org/yiisoft/yii2/builds/20288396

[samdark]

Nice :)

[cebe]

oh, looks like not all the versions are possible. lets wait for the result.

[subdee]

nice try @cebe 👍

This tool could help for trying out snippets on different versions though

[qiangxue]

Good try. @subdee Thanks for the info. It seems 5.4.11, 5.4.12, 5.4.13 all have problem. 5.4.10 and 5.4.21 are fine.

[qiangxue]

Options to deal with this issue:

1. Add documentation about unsupported versions;
2. Modify Arrayable interface;
3. Introduce a different interface and trait for converting an object to an array with customizable fields.

Which one do you like?

[subdee]

My thoughts.

1. Although I expect that most people won't have trouble with their webhosts (I assume webhosts update their PHPs), I'd rather not have such specific revisions preventing developers from using the framework.
2. Not sure, renaming the function destroys consistency. Maybe by defining the same parameters/values as in the trait?
3. I think this could be overkill.

[abrahamgreyson]

I'm not sure but I think maybe people don't like unsupported thing.