Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Travis CI for Yii Basic App #1744

Closed
DavertMik opened this issue Jan 2, 2014 · 12 comments
Closed

Execute Travis CI for Yii Basic App #1744

DavertMik opened this issue Jan 2, 2014 · 12 comments
Assignees
Milestone

Comments

@DavertMik
Copy link
Contributor

Basic app has some Codeception tests and I'd really like to say thank you to @Ragazzo for writing them and @qiangxue for making them run with Yii2 connector )

I think we should connect https://github.com/yiisoft/yii2-app-basic repo to Travis so we could watch for any regression in Yii-Codeception tests. As well we need to cover various tricky aspects in tests like forms, redirections (I think they are mostly covered, but you know better of them).

@Ragazzo, maybe you can provide PR with travis.yml config for that?

@Ragazzo
Copy link
Contributor

Ragazzo commented Jan 2, 2014

I am not into core, someone from core should solve problems with travis.yml, but i think this could be a good idea for testing integration and fixing it asap.

@cebe
Copy link
Member

cebe commented Jan 3, 2014

Well, the tests are mainly provided as examples to show how to test your app. not sure whether it makes sense to run them on travis...

@Ragazzo
Copy link
Contributor

Ragazzo commented Jan 3, 2014

@cebe true, but in this case we will know that something gone bad, but to be true we will know it anyway as someone will report about it.

@qiangxue
Copy link
Member

qiangxue commented Jan 3, 2014

I like the idea of executing travis ci for the basic app. It can be considered as part of the functional tests for the core code.

@samdark
Copy link
Member

samdark commented Jan 3, 2014

I'm for it as well. Having tests and not running these doesn't make sense.

@DavertMik
Copy link
Contributor Author

@cebe green badge on travis will make us confident that examples work as expected.

@Ragazzo
Copy link
Contributor

Ragazzo commented Jan 3, 2014

Ok, so someone from core can start working on it i guess, as it was voted to do so :)

@cebe
Copy link
Member

cebe commented Jan 3, 2014

Working on it.

@ghost ghost assigned cebe Jan 3, 2014
cebe added a commit that referenced this issue Jan 3, 2014
@cebe
Copy link
Member

cebe commented Jan 3, 2014

Added a travis.yml file for basic app. @qiangxue can you please enable travis on the yii2-app-basic repo?

Acceptance tests may not run out of the box. Will fix this when travis support is enabled.

cebe added a commit that referenced this issue Jan 3, 2014
change was made in 0d263a1

issue #1744
@qiangxue
Copy link
Member

qiangxue commented Jan 4, 2014

Added it to travis.

@cebe
Copy link
Member

cebe commented Jan 4, 2014

thanks. here is the link to the builds: https://travis-ci.org/yiisoft/yii2-app-basic/builds
Currently failing. I'll fix that.

@cebe
Copy link
Member

cebe commented Jan 4, 2014

there is currently an issue with travis: travis-ci/travis-ci#1822 waiting for a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants