[READY] Fix for #1581 #1583
Merged
[READY] Fix for #1581 #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $unselectOptions=array('id'=>self::ID_PREFIX.$htmlOptions['id']); | ||
| else | ||
| $unselectOptions=array('id'=>false); | ||
| $hidden=self::hiddenField($hiddenName,$unselect,$unselectOptions); |
There was a problem hiding this comment.
All this IF content can go in the above IF, this way you don't even need the unselect variable.
|
@mdomba Thank you for your feedback. Made refactoring. |
|
@mdomba can you handle checking/merging this one? |
|
@creocoder same/similar refactoring for activeDropDownList ? @samdark of course... already started with checking ;) |
| { | ||
| $hiddenName=$htmlOptions['name']; | ||
| $htmlOptions['name'].='[]'; | ||
| } |
There was a problem hiding this comment.
here... If unselectValue is not set the variable hiddenName is not used, would be good then to leave here just the check and adding of [], if needed, to the name, and then move the $hiddenName=substr($htmlOptions['name'],0,-2); inside the next IF where it belongs.
|
@mdomba Yes similar refactoring for activeDropDownList. $hiddenName var eliminated :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge. Fix for #1581.