Convert middleware to request handler #79
Conversation
xepozz
commented
Jun 17, 2023
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
PR Summary
|
src/Middleware/SwaggerJson.php
Outdated
| use Psr\Http\Server\RequestHandlerInterface; | ||
| use Yiisoft\Cache\CacheInterface; | ||
| use Yiisoft\DataResponse\DataResponseFactoryInterface; | ||
| use Yiisoft\Swagger\Service\SwaggerService; | ||
|
|
||
| final class SwaggerJson implements MiddlewareInterface | ||
| final class SwaggerJson implements RequestHandlerInterface |
There was a problem hiding this comment.
- What's the benefit?
- It's still in the
Middlewarenamespace.
There was a problem hiding this comment.
I'll move it outside of the middleware folder
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
=============================================
- Coverage 92.85% 66.66% -26.20%
- Complexity 20 28 +8
=============================================
Files 5 7 +2
Lines 70 105 +35
=============================================
+ Hits 65 70 +5
- Misses 5 35 +30
☔ View full report in Codecov by Sentry. |
|
@xepozz readme should be adjusted. Afterwards, it's good to merge. |
|
Done |