Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug command #372

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add debug command #372

wants to merge 4 commits into from

Conversation

samdark
Copy link
Member

@samdark samdark commented Sep 13, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues yiisoft/yii-debug#271

@samdark samdark requested review from vjik and xepozz September 13, 2024 09:59
"yiisoft/definitions": "^3.0"
"yiisoft/definitions": "^3.0",
"yiisoft/var-dumper": "^1.7",
"symfony/console": "^5.4|^6.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think symfony/console and related to command dependency should be optional in require-dev section

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 72 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (1ab3bed) to head (19dc9cf).

Files with missing lines Patch % Lines
src/Command/DebugContainerCommand.php 30.76% 72 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##              master     #372       +/-   ##
==============================================
- Coverage     100.00%   86.95%   -13.05%     
- Complexity       164      192       +28     
==============================================
  Files             11       12        +1     
  Lines            448      552      +104     
==============================================
+ Hits             448      480       +32     
- Misses             0       72       +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants