Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegated container #317

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Fix delegated container #317

merged 4 commits into from
Dec 2, 2022

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Nov 30, 2022

Q A
Is bugfix? ✔️

@what-the-diff
Copy link

what-the-diff bot commented Nov 30, 2022

  • The ContainerInterface is injected into the delegate.
  • A new instance of a container is created and passed to the delegate as an argument, instead of passing $this (the current object).

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (80db7b3) compared to base (b4c23bb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #317   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       151       152    +1     
===========================================
  Files             10        10           
  Lines            366       366           
===========================================
  Hits             366       366           
Impacted Files Coverage Δ
src/Container.php 100.00% <100.00%> (ø)
src/ContainerConfig.php 100.00% <0.00%> (ø)
src/CompositeContainer.php 100.00% <0.00%> (ø)
src/Helpers/DefinitionParser.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark
Copy link
Member

samdark commented Dec 1, 2022

Need a test for it.

@xepozz xepozz marked this pull request as ready for review December 2, 2022 17:22
@xepozz xepozz merged commit f184eb1 into master Dec 2, 2022
@xepozz xepozz deleted the fix-delegated-container branch December 2, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants