Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for wrong definition format #315

Closed
wants to merge 4 commits into from
Closed

Add test for wrong definition format #315

wants to merge 4 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Nov 9, 2022

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Depends on yiisoft/definitions#54

@xepozz xepozz added the status:code review The pull request needs review. label Nov 9, 2022
@xepozz xepozz requested a review from a team November 9, 2022 19:25
@what-the-diff
Copy link

what-the-diff bot commented Nov 9, 2022

  • Added a test for non-array arguments

@xepozz xepozz mentioned this pull request Nov 9, 2022
Merged
@vjik
Copy link
Member

vjik commented Nov 13, 2022

Now depends on yiisoft/definitions#57

@xepozz xepozz closed this Dec 2, 2022
@xepozz xepozz deleted the add-more-info-about-error branch December 2, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xepozz @vjik