Lazy services #232
Open
Lazy services #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xepozz
commented
Aug 1, 2021
•
xepozz
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Related issues | #197, yiisoft/definitions#58 |
xepozz
commented
Aug 1, 2021
|
Tests fail because of yiisoft/factory#116 isn't in master |
# Conflicts: # src/Container.php
BoShurik
reviewed
Aug 11, 2021
# Conflicts: # composer.json # src/Container.php # src/ExtensibleService.php # tests/Unit/Helpers/DefinitionParserTest.php
# Conflicts: # src/Container.php
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=============================================
- Coverage 100.00% 98.54% -1.46%
- Complexity 161 168 +7
=============================================
Files 11 11
Lines 466 481 +15
=============================================
+ Hits 466 474 +8
- Misses 0 7 +7 ☔ View full report in Codecov by Sentry. |
|
Adding benchmarking would be great. |
vjik
added
status:under development
BoShurik
reviewed
Aug 2, 2023
| use Yiisoft\Di\Tests\Support\EngineMarkOne; | ||
|
|
||
| class LazyServiceContainerTest extends TestCase | ||
| { | ||
| protected function setUp(): void | ||
| { | ||
| if (!class_exists(\ProxyManager\Factory\LazyLoadingValueHolderFactory::class)) { | ||
| $this->markTestSkipped('You should install `ocramius/proxy-manager` if you want to use lazy services.'); | ||
| if (!class_exists(LazyLoadingValueHolderFactory::class)) { |
* improve * Fix psalm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.