Add test for #157 #172
Merged
Add test for #157 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiqsol
added a commit
to hiqsol/factory
that referenced
this pull request
Oct 1, 2020
- constructor with default values is called properly - skip excessive parameters - pass all arguments if parameter is variadic Fixes: - yiisoft/di#157 - yiisoft/di#172 - yiisoft/di#173
hiqsol
added a commit
to hiqsol/factory
that referenced
this pull request
Oct 2, 2020
- constructor with default values is called properly - throw error on excessive named parameters - pass all arguments if parameter is variadic Fixes: - yiisoft/di#157 - yiisoft/di#172 - yiisoft/di#173
hiqsol
added a commit
to hiqsol/factory
that referenced
this pull request
Oct 2, 2020
- constructor with default values is called properly - throw error on excessive named parameters - pass all arguments if parameter is variadic Fixes: - yiisoft/di#157 - yiisoft/di#172 - yiisoft/di#173
samdark
added a commit
to yiisoft/factory
that referenced
this pull request
Oct 2, 2020
* Fix constructor parameters injecting - constructor with default values is called properly - pass all arguments if parameter is variadic Fixes: - yiisoft/di#157 - yiisoft/di#172 - yiisoft/di#173 Co-authored-by: Alexander Makarov <[email protected]>
samdark
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for constructor with default values is called properly.