Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Fix locale, routes and npm dependencies #597

Merged
merged 10 commits into from
Oct 6, 2023
Merged

Blog: Fix locale, routes and npm dependencies #597

merged 10 commits into from
Oct 6, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Oct 5, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@vjik vjik changed the title Fix locale and routes Fix locale, routes and npm dependencies Oct 5, 2023
@what-the-diff
Copy link

what-the-diff bot commented Oct 5, 2023

PR Summary

  • Updated code formatting settings
    The '.editorconfig' file has been updated with new configuration options to enhance style consistency in PHP and markdown files.

  • Improved project initialization script
    A new Makefile has been added to automate various tasks related to project initiation, managing Docker containers, updating npm and composer packages, and executing composer and npm commands.

  • Adjusted route handling
    Changes in the 'router.php' resulted in better routing configuration bit by using the settings obtained from $config->get('routes') and $config->get('app-routes').

  • Event handling enhancements
    The 'events.php' file has been updated to handle the ApplicationStartup event more effectively. Addition of the SetLocaleEvent improves localization support by setting the locale of the translator.

  • Refactored configuration
    The 'configuration.php' file key routes has been renamed to app-routes, improving clarity and consistency with changes made in 'router.php'.

  • Updated version control exclusions
    The 'package-lock.json' file has been added to the '.gitignore' file to prevent it from being committed to the repository.

  • New package dependencies
    A new 'package.json' file has been added, incorporating Bootstrap as a dependency, facilitating its use throughout the project. This file will be crucial in managing project dependencies moving forward.

This pull request plays a significant role in improving the efficiency of the development environment, route management, event handling, and the addition of new package dependencies.

@vjik vjik requested a review from a team October 5, 2023 13:02
@vjik vjik added the status:code review The pull request needs review. label Oct 5, 2023
@vjik vjik changed the title Fix locale, routes and npm dependencies Blog: Fix locale, routes and npm dependencies Oct 5, 2023
@vjik vjik merged commit fc86f80 into master Oct 6, 2023
10 of 15 checks passed
@vjik vjik deleted the fix branch October 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants