Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure OpenAI Support #222

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Add Azure OpenAI Support #222

merged 1 commit into from
Apr 17, 2023

Conversation

changeforan
Copy link
Contributor

@changeforan changeforan commented Apr 13, 2023

  • 升级 openai 包,以支持 Azure OpenAI
  • 添加了deloyment_id 参数
  • 修改了 chatgptapi_bot使其兼容Azure OpenAI

@yihong0618 yihong0618 requested review from frostming and pjq and removed request for frostming April 13, 2023 05:59
xiaogpt/xiaogpt.py Outdated Show resolved Hide resolved
xiaogpt/bot/azureopenai_bot.py Outdated Show resolved Hide resolved
xiaogpt/xiaogpt.py Outdated Show resolved Hide resolved
xiaogpt/xiaogpt.py Outdated Show resolved Hide resolved
@frostming
Copy link
Collaborator

Azure Open AI已经在openai层面做了很好的兼容,我不明白为啥需要独立一个bot出来(大部分和chatgpt api是一样的)

@changeforan
Copy link
Contributor Author

Azure Open AI已经在openai层面做了很好的兼容,我不明白为啥需要独立一个bot出来(大部分和chatgpt api是一样的)

你是指用gpt-3 bot兼容Azure OpenAI么,我感觉是不行的
请参考这篇:Learn how to work with the ChatGPT and GPT-4 models

其中提到:

If you try to interact with the models the same way you did with the older model series, the models will often be verbose and provide less useful responses.

xiaogpt/bot/azureopenai_bot.py Outdated Show resolved Hide resolved
xiaogpt/bot/azureopenai_bot.py Outdated Show resolved Hide resolved
@frostming
Copy link
Collaborator

建议这个PR只保留Azure OpenAI的部分,其他的改动需要另行讨论和PR。这样我们可以更快地merge

@changeforan
Copy link
Contributor Author

Update:
根据comment,去除了与Azure OpenAI无关的所有改动。删除了单独的Azure bot,仅在现有的chatgptapi_bot里兼容Azure OpenAI

@changeforan changeforan changed the title Add Azure OpenAI bot and other finetune Add Azure OpenAI Support Apr 14, 2023
@frostming frostming merged commit 5cea081 into yihong0618:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants