Update gradle caching #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradle-command-action action uses the arguments as the cache key and restores dependency cache only in the first run. This means, it uses the "changed files" as the cache key, which is the same for all projects, making it useless as they'll override each-other. This PR adds a first invocation to the action and passes the project name as an argument + the toml file. This should allow each sub project to have its own cache. There is a certain risk that this might hit the 5GB cache limit as projects won't share cache, causing them to evict each-other (instead of overriding each-other). We don't force exact so it should at least recover from prefix cache key. Whether this change would help or not is questionable but if we don't get into a cache-eviction race, it might work well. To be explicit, i disabled the cache for subsequent calls to gradle-command-action and also updated it back to @v1 as the previous issue we hit is fixed. gradle/gradle-build-action#70 Bug: n/a Test: CI
when builds fail due to connectivity, they take an absurd amount of time and don't recover. This CL decreases the timeouts to 1 minute but instead doubles the retries to 20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle-command-action action uses the arguments as the cache key and restores dependency cache only in the first run.
This means, it uses the "changed files" as the cache key, which is the same for all projects, making it useless as they'll override each-other.
This PR adds a first invocation to the action and passes the project name as an argument + the toml file.
This should allow each sub project to have its own cache.
There is a certain risk that this might hit the 5GB cache limit as projects won't share cache, causing them to evict each-other (instead of overriding each-other). We don't force exact so it should at least recover from prefix cache key.
Whether this change would help or not is questionable but if we don't get into a cache-eviction race, it might work well.
To be explicit, i disabled the cache for subsequent calls to gradle-command-action and also updated it back to @v1 as the previous issue we hit is fixed.
gradle/gradle-build-action#70
Bug: n/a
Test: CI