Reenable testing #343
Merged
Reenable testing #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This verifies that the doctest/fast-logger issues are all resolved on GHC 7.6 and 7.8.
|
Heh, I was about to write a comment to say I'll merge once the tests pass... and then they passed while typing. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of discussion in #338
This also enables travis CI testing on GHC 7.6 and 7.8, which @kazu-yamamoto and I thought was a good idea. There was a period where the doctests worked on 7.8 but not 7.6 so I wanted to get that in with the PR that reenabled doctests.