-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactorise entire codebase for modularity and cleanup #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
DiscordHandler (Either RestCallErrorCode Message)
to a cleanerDiscordHandler ()
since the returnedMessage
isn't used anywayMessage -> DiscordHandler ()
, orReactionInfo -> DiscordHandler ()
)newCommand
andnewDevCommand
. This abstracts away RegEx matching and subgroup capturing as well as dev checkingsrc/config/~~.conf
to.owen/~~.csv
..csv
files now require a new line at the endfame.csv
anddevs.csv
are now ONE ITEM PER LINE, instead of a comma separated single lineUnchanged
Requesting some local testing or review before actually merging, because although I tested on my machine, most of the code is newly written and therefore prone to mistakes/errors. (...or we can just merge and test in production lmao)