Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with regex handling. #13

Closed
social-anthrax opened this issue Feb 23, 2021 · 2 comments · Fixed by #17
Closed

Inconsistency with regex handling. #13

social-anthrax opened this issue Feb 23, 2021 · 2 comments · Fixed by #17
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@social-anthrax
Copy link
Collaborator

All commands should be handled within Command Handler, with some exceptions for the random rolling functions.
However isFortune, isADA, isThatcher and isNietzsche are all residing within handleEvent.hs making it extremely cluttered.

These should be migrated to CommandHandler.

@social-anthrax social-anthrax added the bug Something isn't working label Feb 23, 2021
@yutotakano yutotakano self-assigned this Feb 23, 2021
@yellowtides
Copy link
Owner

True, haven't considered that we'd get to the point of having so many miscellaneous functions. I think that we should have a seperate miscellaneous folder with all the misc. functionality/REs. Files like ADAPriceFetcher.hs should also be moved there.

@social-anthrax
Copy link
Collaborator Author

As it stands it should be easy for them to be moved straight into the command handler file without any loss of functionality. The files that should be allowed to be there are the ones to do with rolling and random chance.

@social-anthrax social-anthrax added the enhancement New feature or request label Feb 23, 2021
@yutotakano yutotakano added this to Ideas in the cloud in General Development Feb 27, 2021
@yutotakano yutotakano moved this from Ideas in the cloud to Stuff being worked on by someone in General Development Mar 4, 2021
@yutotakano yutotakano linked a pull request Mar 4, 2021 that will close this issue
General Development automation moved this from Stuff being worked on by someone to Done pog Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
General Development
  
Done pog
Development

Successfully merging a pull request may close this issue.

4 participants