Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to generate by for BIDS #870

Closed
wants to merge 1 commit into from

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Aug 16, 2022

this PR is held up until pybids fixes this: bids-standard/pybids#864
Also do not merge this until it is rebased on top of #869

@36000 36000 changed the title [WIP] Update to generate by for BIDS Update to generate by for BIDS Nov 11, 2022
@36000
Copy link
Collaborator Author

36000 commented Nov 11, 2022

Not sure why but this still doesn't work....

@36000
Copy link
Collaborator Author

36000 commented Nov 23, 2022

@arokem could you create a minimal example to demonstrate whether this is a pybids problem?

@arokem
Copy link
Collaborator

arokem commented Nov 23, 2022

I created a gist that replicates the problem that we are seeing: https://gist.github.com/arokem/7505a75031924960fc9c18a88589900e

Along the way, I also found out that the datasets that we create in these tests do not pass BIDS validation, so I had to tweak the test data a little bit to add synthetic "raw" data (this is because you can't have a valid BIDS dataset that doesn't have subject folders at top level).

Nevertheless, these datasets are now BIDS valid, but still when there is only a GeneratedBy field in the dataset_description.json, the call to get with the derivative scope returns an empty list, instead of the list populated with the file pointers to the files that live under that scope. I'll post an issue to the pybids GitHub as well.

@arokem
Copy link
Collaborator

arokem commented Nov 23, 2022

OK - I can confirm that this will be fixed when bids-standard/pybids#864 is merged. So I guess we keep this PR open until that appears in a pybids release version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants