Fix submit review form (go-gitea#11252)

* Fix submit review form Signed-off-by: Andrew Thornton <[email protected]> * placate lint Signed-off-by: Andrew Thornton <[email protected]> * try something different Signed-off-by: Andrew Thornton <[email protected]> * Update web_src/less/_base.less Co-authored-by: techknowlogick <[email protected]>
ydelafollye · Jul 31, 2020 · e2b56e2 · e2b56e2
1 parent acb615b
commit e2b56e2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/templates/repo/diff/new_review.tmpl b/templates/repo/diff/new_review.tmpl
@@ -3,7 +3,7 @@
  <span class="text">{{.i18n.Tr "repo.diff.review"}}</span>
  <i class="dropdown icon"></i>
  </div>
- <div class="menu">
+ <div class="menu review-box">
  <div class="ui clearing segment">
  <form class="ui form" action="{{.Link}}/reviews/submit" method="post">
  {{.CsrfTokenHtml}}

diff --git a/web_src/less/_base.less b/web_src/less/_base.less
@@ -1231,12 +1231,21 @@ i.icon.centerlock {
 
 /* limit width of all direct dropdown menu children */
 /* https://github.com/go-gitea/gitea/pull/10835 */
-.dropdown:not(.selection) > .menu > * {
+.dropdown:not(.selection) > .menu:not(.review-box) > * {
  max-width: 300px;
  overflow-x: hidden;
  text-overflow: ellipsis;
 }
 
+.dropdown:not(.selection) > .menu.review-box > * {
+ @media only screen and (max-height: 700px) {
+ .CodeMirror,
+ .CodeMirror-scroll {
+ min-height: 100px;
+ }
+ }
+}
+
 .text-label {
  display: inline-flex !important;
  align-items: center !important;