Unfortunately go template if does not shortcut (go-gitea#11392)

Go template's `{{if ...}}` does not shortcut its tests therefore it is possible to cause a NPE unless you separate ifs into two. Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye · Jul 31, 2020 · 9b65399 · 9b65399
1 parent 1b6c36c
commit 9b65399
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/templates/repo/commit_page.tmpl b/templates/repo/commit_page.tmpl
@@ -104,8 +104,10 @@
  {{else}}
  <i class="unlock icon"></i>
  {{.i18n.Tr .Verification.Reason}}
- {{if and .Verification.SigningKey (ne .Verification.SigningKey.KeyID "")}}
- <span class="pull-right"><span class="ui text">{{.i18n.Tr "repo.commits.gpg_key_id"}}:</span> <i class="warning icon"></i>{{.Verification.SigningKey.KeyID}}</span>
+ {{if .Verification.SigningKey}}
+ {{if ne .Verification.SigningKey.KeyID ""}}
+ <span class="pull-right"><span class="ui text">{{.i18n.Tr "repo.commits.gpg_key_id"}}:</span> <i class="warning icon"></i>{{.Verification.SigningKey.KeyID}}</span>
+ {{end}}
  {{end}}
  {{end}}
  </div>