Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary zkHosts validation #9

Merged
merged 1 commit into from
Feb 14, 2015

Conversation

patricklucas
Copy link
Contributor

Curator assumes the default ZooKeeper port 2181 if none is specified, so
this validation check is unnecessary.

@yahoocla
Copy link

yahoocla commented Feb 5, 2015

CLA is valid!

@patricklucas
Copy link
Contributor Author

Also, I wasn't able to run the tests after importing the project into IntellIJ because of this one conspicuous error. Not sure what that's about.

Error:(21, 21) object index is not a member of package views.html
      Ok(views.html.index(errorOrClusterList))
                    ^

screen shot 2015-02-04 at 16 14 30

@patelh
Copy link
Collaborator

patelh commented Feb 13, 2015

This happens in IntelliJ since the views aren't rendered. If you run sbt clean compile or activator clean compile, the views will be generated. Then you can run the test in IntelliJ.

Curator assumes the default ZooKeeper port 2181 if none is specified, so
this validation check is unnecessary.
@patricklucas
Copy link
Contributor Author

That indeed fixed the view generation problem, but IntelliJ reports "0 test class found in package" when I execute "Run 'All Tests'".

I ran each test file manually and found this failing test.

patelh added a commit that referenced this pull request Feb 14, 2015
@patelh patelh merged commit 1cd556c into yahoo:master Feb 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants