Enhance topics overview display and remove the lowercase convert of zookeeper host #70
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
|
Fix the nonEmpty member not found bug to avoid compile failed |
|
Remove the clusterconfig case insensitive test cases since the config should be case sensitive |
|
Restore default value of configuration file |
| @@ -91,7 +91,7 @@ class TestKafkaManager extends CuratorAwareTest { | |||
| val future = kafkaManager.getBrokerList("dev") | |||
| val result = Await.result(future,duration) | |||
| assert(result.isRight === true) | |||
| assert(result.toOption.get.nonEmpty === true) | |||
| assert(result.toOption.nonEmpty === true) | |||
There was a problem hiding this comment.
Since this code can't compile, and nonEmpty is a member of Option, directly call noEmpty sounds more scala style.
[error] /home/travis/build/yahoo/kafka-manager/test/kafka/manager/TestKafkaManager.scala:94: value nonEmpty is not a member of kafka.manager.BrokerListExtended
[error] assert(result.toOption.get.nonEmpty === true)
Enhance topics overview display and remove the lowercase convert of zookeeper host
3.Remove the lowercase convert of zookeeper since zookeeper chroot path is case sensive