Feature/dockerization

[linehrr]

by running sbt docker, you will get a docker image kafka-manager:<version> locally.
then by running docker run -d -e<ENV VARS> kafka-manager:<version>, you will have a running kafka-manager instance listening to port 9000.
port could be mapped to any other port with -p<any port>:9000 in docker run option.

[linehrr]

can anyone take a look at this PR ? this PR will make docker building very simple. and version will be always matching version that's defined in sbt.

[linehrr]

do we have targeted release for this to be merged in?

[glasser]

Neat! Any plan to make a docker hub repo for official releases?

[linehrr]

Good idea. We can create an organization first. R

On Wed, Dec 19, 2018 at 5:55 PM David Glasser ***@***.***> wrote: Neat! Any plan to make a docker hub repo for official releases? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABEnE1kpUe_0vHZXOq29O2J0dBmfyPLrks5u6sPbgaJpZM4YdAYm> .

-- *Best Regards* *Ryne*

[linehrr]

I've created a repo here: https://cloud.docker.com/u/kafkamanager/repository/list
I can transfer the ownership to anyone who's willing to maintain this repo.

[patelh]

what would it entail?

[linehrr]

@patelh we will have an 'official dockerhub' for releasing official images for anyone who wants to deploy this kafka manager. versions will be preserved through image tags so ppl can use older versions if they wish. and also since this manager most of the time only needs $ZK_HOSTS env var to be injected, this makes it perfect to fit in containerization and to be env agnostic plus all meta data writes into zookeeper, no local storage needed, which also makes it ephemeral and plays nicely inside container orchestration frameworks.
therefore I think it would be a great idea to make an official docker hub repo for this project.
what do you guys think ?

[ziru]

I stumbled upon this repo on dockerhub.
https://hub.docker.com/r/kafkamanager/kafka-manager/tags

Thanks for putting efforts to release official images. Is it possible to add a latest tag?

[linehrr]

@ziru we could, but someone need to maintain this docker repo and make sure the 'latest' is the latest. if you want I can make you as one of the owner so you can also maintain the latest tag anytime new version comes out.

[ziru]

@linehrr Sounds good to me. I can help maintain the docker repo.
How did you publish the image to docker hub? Manually?

[linehrr]

@ziru right now it's manually, but I really like someone to add CI hook into github so anytime we have a new release tag, it can build automatically.
please give me your dockerhub username so I can add you as owner.

[ziru]

@linehrr yup, auto push would be great. here is my dockerhub account: https://hub.docker.com/u/ziru

[linehrr]

@ziru added, you are owner and maintainer now.

[ziru]

@linehrr thanks! done with publishing the 1.3.3.22 image with the latest tag to docker hub.

[joekohlsdorf]

I propose that we instead automate the build and push of release tags.
CircleCI for example is free for open source projects: https://circleci.com/docs/2.0/oss/

[rajat404]

@linehrr @ziru Can you please point me to the Dockerfile. Wanted to read the code.
Thanks!

[linehrr]

@rajat404 it's integrated into sbt. take a look at build.sbt file.

[metao1]

consider upgrading jdk version

[metao1]

You are using jdk8 while the minimum requirements is 11+ in project readme