Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in 1.0.0 and 0.11.0.2 as valid versions #454

Merged
merged 4 commits into from
Mar 16, 2018
Merged

Conversation

icco
Copy link
Contributor

@icco icco commented Dec 8, 2017

The newest versions, both which came out in November, 2017: https://kafka.apache.org/downloads

I don't know if there are other compatibility changes that need to be made, but #451 implies that probably not.

@yahoocla
Copy link

yahoocla commented Dec 8, 2017

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@icco
Copy link
Contributor Author

icco commented Dec 8, 2017

I signed the CLA

@icco
Copy link
Contributor Author

icco commented Dec 8, 2017

@patelh I made this and tried to keep as close to #424 as possible. I didn't add 1.0.0 to Readme in case people find regressions.

@patelh
Copy link
Collaborator

patelh commented Jan 4, 2018

Sorry been out on vacation, will look at this next week but first glace looks good to go.

@xiaoyuan0821
Copy link

Kafka 1.0.0 have been released for 2 more months, any progress on this?

@nullne
Copy link

nullne commented Feb 5, 2018

it seems everything is ok? when will it be merged into master branch?

@yzang
Copy link

yzang commented Feb 6, 2018

When will this be merged into the master?

@TheMonolithX64
Copy link

Ran this locally and all seems fine. All tests passing as well. This resolves issue of "Sum of partition offsets" always 0 in #459 due to https://github.com/yahoo/kafka-manager/blob/master/app/kafka/manager/actor/cluster/KafkaStateActor.scala#L160

[info] TestClusterConfig:  
[info] - invalid name  
[info] - invalid kafka version  
[info] - serialize and deserialize 0.8.1.1  
[info] - serialize and deserialize 0.8.2.0 +jmx credentials  
[info] - serialize and deserialize 0.8.2.0  
[info] - serialize and deserialize 0.8.2.1  
[info] - serialize and deserialize 0.8.2.2  
[info] - deserialize without version, jmxEnabled, and security protocol  
[info] - deserialize from 0.8.2-beta as 0.8.2.0  
[info] - deserialize from 0.9.0.1  
[info] - serialize and deserialize 0.10.0.0  
[info] - serialize and deserialize 0.10.1.0  
[info] - serialize and deserialize 0.10.1.1  
[info] - serialize and deserialize 0.10.2.0  
[info] - serialize and deserialize 0.10.2.1  
[info] - serialize and deserialize 0.11.0.0  
[info] - serialize and deserialize 0.11.0.2  
[info] - serialize and deserialize 1.0.0  
[info] ScalaTest  
[info] Run completed in 2 minutes, 51 seconds.  
[info] Total number of tests run: 155  
[info] Suites: completed 16, aborted 0  
[info] Tests: succeeded 155, failed 0, canceled 0, ignored 0, pending 0  
[info] All tests passed.  
[info] Passed: Total 155, Failed 0, Errors 0, Passed 155  
[success] Total time: 178 s, completed 09-Feb-2018 20:37:53```

TheMonolithX64 added a commit to TheMonolithX64/kafka-manager that referenced this pull request Mar 2, 2018
TheMonolithX64 added a commit to TheMonolithX64/kafka-manager that referenced this pull request Mar 2, 2018
@patelh patelh merged commit 625bb7e into yahoo:master Mar 16, 2018
@icco icco deleted the patch-1 branch March 17, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants