-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
오픈 마켓 [STEP 2] 아리,제리 #93
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
a65df63
refoctor: 상품수정, Secret 조회 중복되는 부분을 메소드로 분리 #6
leeari95 2d57799
refactor: 테스트코드 내 force Unwrapping 옵셔널하게 수정 #6
llghdud921 78543f2
style: SwiftLint에 Conditional Returns on Newline 룰을 추가
leeari95 8bb770b
feat: navigationController, segmentControl 추가 및 속성 구현 #7
llghdud921 3a15dd3
feat: Main에 CollectionView를 올리고 GridCollectionViewCell을 추가 #7
leeari95 9f4aa1e
feat : Main에 ListCollectionViewCell을 추가 #7
llghdud921 7ed3ef7
style: listCollectionViewCell 디테일하게 view 수정
llghdud921 aed288c
feat: 세그먼트 컨트롤러를 활용하여 List와 Grid 형태로 넘어갈 수 있도록 기능 추가 #7
leeari95 9a7fa20
feat: Http로 network하여 collectionview 로드 #7
llghdud921 76c9867
feat: 데이터를 가져오는 동안 로드중임을 알 수 있게 UIActivityIndicatorView 기능 추가 #7
leeari95 33e0482
fix: multipartform body구성 시 마지막 boundary 추가 #6
llghdud921 d000fcc
feat: 상품 가격 레이블들의 색상, 스타일을 설정하는 기능 추가 #7
leeari95 c3ad5cf
fix: gridlayoutcell내 stackview constraint 삭제 #7
llghdud921 7c37bd4
feat: 상품등록 화면으로 이동하는 버튼 추가 후 Modal을 띄우도록 기능 구현 #7
leeari95 900d5c7
refactor: Collectionview를 custom class로 분리 #7
llghdud921 fabfe1f
refactor: ProductCell 내부를 리팩토링 #8
leeari95 224a55d
refactor: ActivityIndicatorView didset 코드 삭제 #8
llghdud921 f4f5995
refactor: 상품등록 버튼의 Segue Kind를 modal에서 Show로 변경 #8
leeari95 a53f698
refator: 잘못된 URL 수정 #8
llghdud921 6bbf36d
refactor: NetworkManager, MultipartForm 부분 리팩토링 #8
leeari95 29779f4
refactor: networkmanager내 request 옵셔널 타입 수정 #8
llghdud921 bdfe1fb
refactor: network 후에 collectionview 구성하도록 수정 #8
llghdud921 ad61002
refactor: 하드코딩 되어있는 메세지 부분을 네임스페이스로 리팩토링 #8
leeari95 b359b2b
docs: STEP2 README 작성
llghdud921 ab7156f
refactor: Asset에 등록되어있는 이미지 이름, Scales, Resizing 설정 수정 #9
leeari95 ffd54e1
refactor: 전반적인 네이밍 수정 #9
llghdud921 b1aeb83
refactor: 뷰 구성 시 cell을 바인딩 하지 못할 경우 에러 발생 얼럿을 띄우도록 수정 #9
leeari95 3b91e40
refactor: identifier로 뷰 전환하는 조건문삼항연산자로 개선 #9
llghdud921 c08cc5b
refactor: NetworkManager 프로퍼티가 private 하도록 접근제어 추가 #9
leeari95 ceaf667
refactor: 동적으로 레이아웃을 잡도록 UICollectionViewDelegateFlowLayout을 채택 #9
leeari95 782bc75
refactor: 동적 레이아웃을 위한 collectionview 프로퍼티 생성 #9
llghdud921 e3a8a37
style: Asset 이미지 이름에 공백부분을 삭제하여 파일명 개선 #9
leeari95 aa1c79a
refactor: 줄바꿈 컨벤션에 맞춰 개선 #9
llghdud921 e8e87c6
style: 메소드명 오타를 수정 #9
leeari95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs: STEP2 README 작성
- Loading branch information
commit b359b2beefebb0693af88d8add5ca2b35fdef8e0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
크 스텝2도 역시 소홀히 하지 않으셨군요!
최고입니다👍👍👍