refactor: 에러의 케이스중 네이밍을 명확하게 개선 #6

OpenMarket/OpenMarket/Error/ParserError.swift

@@ -9,16 +9,16 @@ import Foundation
 
 enum ParserError: LocalizedError {
     case assestNotfound
-    case decoding
-    case encoding
+    case decodingFail
+    case encodingFail
 
     var errorDescription: String {
         switch self {
         case .assestNotfound:
             return "에셋 데이터를 찾을 수 없습니다."
-        case .decoding:
+        case .decodingFail:
             return "디코딩을 하는 도중 에러가 발생했습니다."
-        case .encoding:
+        case .encodingFail:
             return "인코딩을 하는 도중 에러가 발생했습니다."
         }
     }

OpenMarket/OpenMarket/Model/Network/NetworkManager.swift

@@ -36,7 +36,7 @@ struct NetworkManager {
                 case .success(let jsonDecode):
                     completion(.success(jsonDecode))
                 case .failure:
-                    completion(.failure(ParserError.decoding))
+                    completion(.failure(ParserError.decodingFail))
                 }
             case .failure(let error):
                 completion(.failure(error))
@@ -72,7 +72,7 @@ struct NetworkManager {
         case .success(let data):
             encodeData = data
         case .failure:
-            return .failure(ParserError.encoding)
+            return .failure(ParserError.encodingFail)
         }
         var request = URLRequest(url: url)
 
@@ -109,7 +109,7 @@ struct NetworkManager {
         case .success(let data):
             encodeData = data
         case .failure:
-            return .failure(ParserError.encoding)
+            return .failure(ParserError.encodingFail)
         }
         var request = URLRequest(url: url)
 

OpenMarket/OpenMarket/Model/Parser.swift

@@ -16,21 +16,21 @@ struct Parser: Parserable {
             return .failure(.assestNotfound)
         }
         guard let decodeData = try? jsonDecoder.decode(decodingType, from: asset.data) else {
-            return .failure(.decoding)
+            return .failure(.decodingFail)
         }
         return .success(decodeData)
     }
 
     func decode<T: Decodable>(source: Data, decodingType: T.Type) -> Result<T, ParserError> {
         guard let data = try? jsonDecoder.decode(decodingType, from: source) else {
-            return .failure(.decoding)
+            return .failure(.decodingFail)
         }
         return .success(data)
     }
 
     func encode<T: Encodable>(object: T) -> Result<Data, ParserError> {
         guard let data = try? jsonEncoder.encode(object) else {
-            return .failure(.encoding)
+            return .failure(.encodingFail)
         }
         return .success(data)
     }

OpenMarket/OpenMarketTests/Test Doubles/StubParser.swift

@@ -17,7 +17,7 @@ struct StubParser: Parserable {
             let product = Product(id: 1, vendorID: 1, name: "", thumbnail: "", currency: .krw, price: 1, bargainPrice: 1, discountedPrice: 1, stock: 1, createdAt: "", issuedAt: "", images: nil, vendors: nil)
             return .success(product as! T)
         } else {
-            return .failure(ParserError.decoding)
+            return .failure(ParserError.decodingFail)
         }
     }