Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

쥬스메이커 [STEP 3] 제이티, Ari #135

Closed
wants to merge 29 commits into from
Closed

쥬스메이커 [STEP 3] 제이티, Ari #135

wants to merge 29 commits into from

Commits on Nov 1, 2021

  1. feat: 재고수정 화면 진입시 Label, Stepper의 Value 연동 기능 구현 

    - JuiceMakerViewController에 prepare 메소드 구현
- 현 재고의 갯수를 재고수정 화면에도 연동 기능 추가
- FruitStoreViewController 내부에 Stepper setup 관련 메소드 3개 구현
    @leeari95
    leeari95 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    3d2a6da View commit details
    Browse the repository at this point in the history

  2. feat: FruitStore에서 Label과 Stepper의 값 연동 및 Stepper 터치 시 Label 값 변환 구현

    @HoneyCoding
    HoneyCoding committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    1e85463 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. feat: Stepper를 클릭시 재고가 계산되도록 기능 구현 

    - stepperTapped 내부에 계산하는 로직 추가
- 계산과 관련된 메서드 3개 추가 (fruitStockChange, chooseCalculator, calculateFruitStock)
    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    df7531a View commit details
    Browse the repository at this point in the history

  2. fix: FruitStore의 잘못된 조건문 수정

    @HoneyCoding
    HoneyCoding committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    23a4bdc View commit details
    Browse the repository at this point in the history

  3. fix: 재고 부족시 재고수정으로 넘어갈 때 Label 반영 안되는 버그 수정

    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    febd113 View commit details
    Browse the repository at this point in the history

  4. refactor: JuiceMakerViewController의 중복 코드를 빼주어 메소드 setupNextViewLabel… 

    …(of:) 추가
    @HoneyCoding
    HoneyCoding committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    bd2ac42 View commit details
    Browse the repository at this point in the history

  5. refactor: stepperTapped 내부 가독성을 위해 fruitLabelText 메소드 추가하여 리팩토링

    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    9b545cf View commit details
    Browse the repository at this point in the history

  6. fix: Storyboard에서 JuiceMakerViewController Scene의 Content Priority 충돌… 

    … 오류 수정
    @HoneyCoding
    HoneyCoding committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    e71fa4f View commit details
    Browse the repository at this point in the history

  7. fix: Button titleLabel이 버튼의 너비에 fit되도록 설정, 글꼴 자동 업데이트 설정

    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    b9d4c03 View commit details
    Browse the repository at this point in the history

  8. refactor: JuiceMakerViewController의 코드를 extension을 사용해 분리

    @HoneyCoding
    HoneyCoding committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    4864c3c View commit details
    Browse the repository at this point in the history

  9. refactor: FruitStoreViewController 내부 extension으로 분리

    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    93bf54e View commit details
    Browse the repository at this point in the history

  10. fix: Storyboard의 Stepper와 연결된 stepperTapped 메소드의 Sent Events 변경

    @HoneyCoding
    HoneyCoding committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    484a0a1 View commit details
    Browse the repository at this point in the history

  11. chore: 의미없는 줄바꿈과 프로퍼티 삭제

    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    2b397db View commit details
    Browse the repository at this point in the history

  12. chore: 기존 코드에서 오버 스펙으로 구현한 부분 제거

    @HoneyCoding
    HoneyCoding committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    1fec18c View commit details
    Browse the repository at this point in the history

  13. docs: README.md 파일 내부에 STEP 3 관련 내용 추가

    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    da64fc6 View commit details
    Browse the repository at this point in the history

  14. docs: README.md 파일 수정하다가 빠진 STEP 2 내용 다시 추가

    @leeari95
    leeari95 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    ccb8a10 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. refactor: 메소드 네이밍 동사로 시작하도록 수정

    @HoneyCoding
    HoneyCoding committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    ae7582e View commit details
    Browse the repository at this point in the history

  2. docs: READMD.md 파일 내용 추가

    @leeari95
    leeari95 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    3a3c801 View commit details
    Browse the repository at this point in the history

  3. refactor: chooseCalculator 메소드 내에서 switch 문 사용을 if 문 사용으로 수정

    @HoneyCoding
    HoneyCoding committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    82c2aa5 View commit details
    Browse the repository at this point in the history

  4. refactor: currentStockLabelUpdate 메소드 이름을 동사로 수정

    @leeari95
    leeari95 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    119b6d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. refactor: JuiceMakerViewController, JuiceMaker, FruitStore 리팩토링 

    - FruitStore에서 NotificationCenter에 전달하는 object를 기존의 fruit에서 fruit과 stock을 함께 보내도록 수정
- JuiceMaker의 fruitStore에 붙어 있는 private access control을 제거
- JuiceMakerViewController에서 Notification을 통해 받아오는 object의 값이 수정됨에 적합하게 코드 수정
- updateCurrentStockLabel 메소드 내부의 singleton 사용 코드 제거
- updateFruitLabels 메소드 내부에서 stock 값을 직접 받아 사용하도록 수정
    @HoneyCoding
    HoneyCoding committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    288fe58 View commit details
    Browse the repository at this point in the history

  2. refactor: 기존에 Singleton 패턴을 삭제 

    - FruitStore 내부 싱글톤 구현을 제거함
- JuiceMaker 내부 init을 싱글톤이 아닌 FruitStore init() 호출로 수정
- JuiceMakerViewController 내부 화면 전환 로직 수정
- FruitStoreViewController 내부 JuiceMaker 인스턴스를 저장하는 프로퍼티 추가
- FruitStoreViewController 내부에서 Singleton을 활용했던 부분 전체적으로 수정
    @leeari95
    leeari95 committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d8f244d View commit details
    Browse the repository at this point in the history

  3. feat: UIButton에 extension을 통해 메소드 추가 및 기존 코드 일부 수정

    @HoneyCoding
    HoneyCoding committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    ba4de9c View commit details
    Browse the repository at this point in the history

  4. refactor: fruitLabelChanged 메소드 이름을 fruitStockChanged로 수정

    @leeari95
    leeari95 committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6a7ae09 View commit details
    Browse the repository at this point in the history

  5. feat: FruitStoreViewController가 deinit될 때 Notification 제거 코드 추가

    @HoneyCoding
    HoneyCoding committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dc428fe View commit details
    Browse the repository at this point in the history

  6. docs: README.md 내부 개선사항 내용 추가

    @leeari95
    leeari95 committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    981c869 View commit details
    Browse the repository at this point in the history

  7. docs: README.md 수정

    @leeari95
    leeari95 committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    abef023 View commit details
    Browse the repository at this point in the history

  8. docs: README.md 내부 수정

    @leeari95
    leeari95 committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    827e98b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2021

  1. docs: README.md 내부 오타와 UML 이미지 수정

    @leeari95
    leeari95 committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    4809668 View commit details
    Browse the repository at this point in the history