-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
일기장 [STEP 2] Zion, Serena #136
Open
serena0720
wants to merge
36
commits into
yagom-academy:ic_9_serena
Choose a base branch
from
serena0720:Step2
base: ic_9_serena
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f14e295
feat: CoreData과 DiaryCoreData 생성 및 CRUD 구현
serena0720 f586ac6
feat: ActivityViewControllerShowable, AlertControllerShowable 타입 구현완료
LeeZion94 8536d5c
feat: ViewController에 Showable Type 적용
LeeZion94 359557c
refactor: AppManager에 DiaryDataManager 주입
serena0720 165c338
refactor: DiarySample 삭제 및 DiaryEntity 타입 적용
serena0720 0759a83
refactor: DiaryEntity 변수 타입 수정 및 컨벤션 수정
serena0720 8195eef
refactor: DiaryDetailViewController 파라미터 수정
serena0720 39faa79
feat: createDiaryData 생성
serena0720 c5c5b60
feat: viewWillAppear 시 dataFetch
LeeZion94 469ba3a
feat: DiaryDetailViewController Update 기능 연결
LeeZion94 723ae29
refactor: 불필요 커밋 삭제
LeeZion94 701dba8
feat: deleteAction 구현
serena0720 f5dee66
feat: DiaryDetailViewController Delete 메소드
serena0720 500f635
feat: Update, Create 예외처리 추가
LeeZion94 9fcf716
feat: TextView EndEditing시 Save로직 추가
LeeZion94 6c34cff
feat: NotificationCenter Observer 등록
serena0720 97bb291
feat: background 시 create 로직 추가 및 예외처리
LeeZion94 9974d9a
feat: Activity Share Action 생성
serena0720 9269899
feat: date 출력 추가 및 becomeResponder 추가
LeeZion94 bc89e58
feat: diffableDataSource delete시 bottom Constraint 충돌해결
LeeZion94 b5ae868
refactor: 사용하지 않는 model 삭제
LeeZion94 021fc0f
refactor: private 누락 수정
serena0720 7125c8a
fix: title만 존재할경우 body도 title처럼 나오는 이슈 수정
LeeZion94 9cce9b2
Merge remote-tracking branch 'origin/Step2' into Step2
LeeZion94 21cc6ff
fix: insertData로직 추가 및 data Create반환 값 삭제, DiaryCoreDataManager 삭제
LeeZion94 678318f
refactor: 불필요한 메소드 삭제
serena0720 d97d383
refactor: insertData 에러 수정
serena0720 c41d293
feat: CoreData 수정 및 DiaryContentsDTO 생성
LeeZion94 575b0cd
feat: DiaryDetailViewController UseCase 생성 및 적용
LeeZion94 258deca
feat: 누락 수정사항 추가
LeeZion94 12cccf3
feat: CoreDataManagerType 생성 및 적용
LeeZion94 0d8b23d
fix: Save 시 Fetch 타이밍 수정
LeeZion94 ed70720
fix: Delete가 되지 않는 문제 수정
LeeZion94 c5a27c2
docs: Step2 README 작성
serena0720 b3a7146
chore: 컨벤션 통일
serena0720 8fc9f0e
Merge branch 'Step2' of https://github.com/serena0720/ios-diary into …
serena0720 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: Activity Share Action 생성
- Loading branch information
commit 9974d9a6895fd4b54ba689509d310c3ab7f880c0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기 Private 붙일 수 있을 것 같아요 ㅎㅎ