박스오피스 [Step2-3] Toy,Morgan #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havilog
requested changes
Dec 13, 2023
| // | ||
| import Foundation | ||
|
|
||
| struct Endpoint { |
There was a problem hiding this comment.
endpoint를 struct로 하는 것은 구현 취향의 문제일거 같은데,
movie 관련된 endpoint들,
home 관련된 endpoint들,
setting 관련된 endpoint들
등 이런식으로 나눠지고
각각의 엔드포인트에 대한 케이스가 정의되는 곳이 필요할 것 같아요
지금은 뷰컨쪽에서 일일히 다 넣어주고 있는데
메소드나 헤더 같은 경우는 이미 정의되어있어서
파라미터만 다이나믹하게 넣어주면 될 것 같아요
또한 파라미터를 인코딩하는 로직이 빠져있는데 이 부분도 챙겨주세요
그리고 마임같은 경우도 꼭 파라미터로 받아야할지 의문이긴 해요
꼭 받아야한다 라는 의미는
디폴트 밸류를 주거나 옵셔널이어도 되지 않을까 싶어요
havilog
reviewed
Dec 15, 2023
| } | ||
|
|
||
| guard let httpResponse = response as? HTTPURLResponse, (200...299).contains(httpResponse.statusCode) else { | ||
| print(NetworkManagerError.responseError) |
There was a problem hiding this comment.
complitionHandler 이용하여 에러처리 하였습니다!
BoxOffice/Network/Endpoint.swift
Outdated
Comment on lines
34
to
43
| func asURLPostRequset(data: Data) throws -> URLRequest { | ||
| guard let url = api.getURL(apikey: Key.movieDataApiKey, queryItems: queryItems) else { throw URLError.invalidURL } | ||
|
|
||
| var request = URLRequest(url: url) | ||
| request.httpMethod = httpMethod.rawValue | ||
| request.addValue(mime.rawValue, forHTTPHeaderField: httpHeaderField.rawValue) | ||
| request.httpBody = data | ||
|
|
||
| return request | ||
| } |
There was a problem hiding this comment.
파라미터 인코딩에 대한 내용은 여전히 빠져있는거 같은데 이 부분도 수정이 되는 부분일까요?
There was a problem hiding this comment.
url 을 getURL 메서드를 통해서 만들어주고 NetworkManager에서 인코딩 된 데이터를 asURLPostRequest 메서드의 파라미터에 넣어 네트워킹을 하고 있습니다. 인코딩 자체를 asURLPostRequest 메서드 내부에서 해야한다는 말씀이신지 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@havilog
하비 endpoint 작업하여 다시 PR 보냅니다!