Only add schemes to URLs with hostnames #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 3dfc087 on kevindew:single-slash-link into ** on yabwe:master**. |
|
@kevindew looks like this conflicts with your previous change that got merged in. Could you fix the merge conflict and then we can get this guy in too? |
3dfc087
to
6d67581
Compare
Fixes: yabwe#1250 This changes the way a scheme is prefixed to a URL when linkValidation is on. Previously any URL that did not match the scheme regex would be prefixed with 'https://' which meant that an absolute path such as '/' would be changed to 'https:///' This changes it so that the 'https://' is only prefixed if the first part of the path looks like a hostname, which allows absolute paths to be unchanged and most relative paths to be unchanged. I say most as a path such as "test.txt" would be matched as a hostname and converted to 'https://test.txt' but this seems an acceptable trade off and definitely better than trying to store a list of valid TLDs so filenames and hostnames can be determined.
|
Changes Unknown when pulling 6d67581 on kevindew:single-slash-link into ** on yabwe:master**. |
|
@nmielnik sure, I've rebased it against master now. |
|
Awesome, all the tests pass in saucelabs, thanks for this @kevindew ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1250
This changes the way a scheme is prefixed to a URL when linkValidation
is on. Previously any URL that did not match the scheme regex would be
prefixed with 'https://' which meant that an absolute path such as '/'
would be changed to 'https:///'
This changes it so that the 'https://' is only prefixed if the first part
of the path looks like a hostname, which allows absolute paths to be
unchanged and most relative paths to be unchanged.
I say most as a path such as "test.txt" would be matched as a hostname and
converted to 'https://test.txt' but this seems an acceptable trade off
and definitely better than trying to store a list of valid TLDs so
filenames and hostnames can be determined.