Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1123 Fixes issue with electron environment #1125

Merged
merged 2 commits into from
Jun 20, 2016
Merged

Conversation

sajus
Copy link

@sajus sajus commented Jun 20, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets 1123
License MIT

Description

Bug-ID #1123, fixes issue with electron environment.

@@ -1,6 +1,7 @@
(function (root, factory) {
'use strict';
if (typeof module === 'object') {
var isElectron = typeof module == 'object' && process && process.versions && process.versions.electron;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be === instead of ==

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j0k3r, thanks for pointing this out. I have updated this now.

@j0k3r j0k3r merged commit d71cf26 into yabwe:master Jun 20, 2016
@j0k3r
Copy link
Contributor

j0k3r commented Jun 20, 2016

Thanks ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants