chore: add quiet option to arguments #234
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to write a script with SpoofDPI and found out that it doesn't have a quiet option. There is a
-banner
option that does nothing (it's true in the config by default). It is implied that the quiet option disables any output.Moreover, in the code I found the
util.PrintSimpleInfo
function which never executes becauseconfig.Banner
is always true. Maybe we should think about it. Personally, I like the banner by default, but it seems a little strange that we never useutil.PrintSimpleInfo
. Maybe we should delete it.