Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add quiet option to arguments #234

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: add quiet option to arguments #234

wants to merge 6 commits into from

Conversation

IAGrig
Copy link

@IAGrig IAGrig commented Sep 2, 2024

I tried to write a script with SpoofDPI and found out that it doesn't have a quiet option. There is a -banner option that does nothing (it's true in the config by default). It is implied that the quiet option disables any output.
Moreover, in the code I found the util.PrintSimpleInfo function which never executes because config.Banner is always true. Maybe we should think about it. Personally, I like the banner by default, but it seems a little strange that we never use util.PrintSimpleInfo. Maybe we should delete it.

@Ledorub
Copy link
Collaborator

Ledorub commented Sep 2, 2024

There is a -banner option that does nothing (it's true in the config by default)

-banner=false

@IAGrig
Copy link
Author

IAGrig commented Sep 2, 2024

We don't have a quiet mode anyway. I hope the maintainer finds this useful.

@xvzc
Copy link
Owner

xvzc commented Sep 3, 2024

Maybe we should just remove --banner option. And --silent would be better for the naming of this option.

@xvzc xvzc changed the title feat: add quiet option to arguments chore: add quiet option to arguments Sep 3, 2024
@xvzc xvzc added the chore label Sep 3, 2024
@Ledorub
Copy link
Collaborator

Ledorub commented Sep 3, 2024

@xvzc, maybe we should mention somewhere in the docs how to set bool options to false. It confuses a lot of people, it seems.

@harryqt
Copy link

harryqt commented Sep 3, 2024

Maybe we should just remove --banner option. And --silent would be better for the naming of this option.

Sounds good to me.

@IAGrig
Copy link
Author

IAGrig commented Sep 3, 2024

Maybe we should just remove --banner option. And --silent would be better for the naming of this option.

I can do it, if it's the final decision.

@xvzc
Copy link
Owner

xvzc commented Sep 3, 2024

Maybe we should just remove --banner option. And --silent would be better for the naming of this option.

I can do it, if it's the final decision.

Yeah please go ahead

@IAGrig
Copy link
Author

IAGrig commented Sep 3, 2024

Well, it's worth deleting the unused config.PrintSimpleInfo function or are we planning to use it?

@xvzc
Copy link
Owner

xvzc commented Sep 4, 2024

You can just delete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants