fix: More deep error messages #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(if pkg/errors is too big to include in project, i can rewrite code using std errors.Joins) |
|
Can't it be done with fmt.Errorf()? |
|
@xvzc you are right! ty. I've rewrited code using fmt.Errorf |
Ledorub
reviewed
Aug 21, 2024
util/os.go
Outdated
| @@ -19,18 +19,16 @@ func SetOsProxy(port int) error { | |||
|
|
|||
| network, err := getDefaultNetwork() | |||
| if err != nil { | |||
| return fmt.Errorf("failed to get network interfaces, stdout: %s: %w", string(network), err) | |||
| return fmt.Errorf("failed to get network interfaces: %w", err) | |||
There was a problem hiding this comment.
I think it should be network or network service. We extract an interface from the route command and try to find a NS that uses it.
There was a problem hiding this comment.
I rewrote it as failed to get default network, cause we are calling getDefaultNetwork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without proposed changes, errors on start are very hard to debug.
For example, if i start app with
spoof-dpi -system-proxy=true -debugI will get:
But with given changes error message is less difficult to understand
(whole problem was with no admin privileges)