Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AddTable parameter types #9

Merged
merged 1 commit into from
May 15, 2023
Merged

fix AddTable parameter types #9

merged 1 commit into from
May 15, 2023

Conversation

spearmootz
Copy link
Contributor

PR Details

Current types are wrong.

Description

if you do wb.AddTable("Sheet1", "A1:B2"); you get invalid arguments

in fact the program expects wb.AddTable("Sheet1", { Range: "A1:B2");

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #9 (6a89f22) into main (dc8bf36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files           1        1           
  Lines        2695     2695           
=======================================
  Hits         2649     2649           
  Misses         35       35           
  Partials       11       11           
Flag Coverage Δ
unittests 98.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2023
@xuri xuri merged commit 958999d into xuri:main May 15, 2023
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants