add judgment on global.crypto #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 98.47% 98.65% +0.18%
==========================================
Files 1 1
Lines 3011 2604 -407
==========================================
- Hits 2965 2569 -396
+ Misses 35 24 -11
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xuri
added
the
size/XS
woess
reviewed
Mar 19, 2024
src/index.js
Outdated
| randomFillSync(b); | ||
| } | ||
| }; | ||
| } | ||
| global.performance = { |
There was a problem hiding this comment.
I suggest to do this also for global.performance. Node.js already has performance.now(), so there should be no need to patch it in most cases.
There was a problem hiding this comment.
Good! Thanks for your advice!
xuri
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Fix #22
Description
Related Issue
fix #22
Motivation and Context
How Has This Been Tested
Types of changes
Checklist