Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to ECMAScript modules with mjs file extension #21

Merged
merged 12 commits into from
Mar 11, 2024
Merged

Conversation

peng
Copy link
Collaborator

@peng peng commented Feb 27, 2024

PR Details

  • Change require to import.
  • Add script and change file place in package.json.
  • Add lock file to lock version

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (2d569af) to head (6feeed7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   98.46%   98.65%   +0.19%     
==========================================
  Files           1        1              
  Lines        2992     2604     -388     
==========================================
- Hits         2946     2569     -377     
+ Misses         35       24      -11     
  Partials       11       11              
Flag Coverage Δ
unittests 98.65% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuri xuri added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 2, 2024
@peng peng closed this Mar 10, 2024
@peng peng deleted the fix-build branch March 10, 2024 04:09
@peng peng reopened this Mar 10, 2024
@xuri xuri added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 11, 2024
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri changed the title Fix build Support to ECMAScript modules with mjs file extension Mar 11, 2024
@xuri xuri merged commit 1bcf407 into xuri:main Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants